Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[janus-pp-rec] Huge opus files when received timestamp is 0 (see #2328) #2414

Closed
atoppi opened this issue Oct 30, 2020 · 4 comments · Fixed by #2467
Closed

[janus-pp-rec] Huge opus files when received timestamp is 0 (see #2328) #2414

atoppi opened this issue Oct 30, 2020 · 4 comments · Fixed by #2467

Comments

@atoppi
Copy link
Member

atoppi commented Oct 30, 2020

Since #2328 contained a patch with a not acceptable solution, we are creating this issue to keep track of the post-processor problem described in the PR.
Please refer to #2328 for more context.

@atoppi
Copy link
Member Author

atoppi commented Dec 1, 2020

fyi #2345 has been merged, so I I'll start working again on this.

@atoppi
Copy link
Member Author

atoppi commented Dec 2, 2020

@ihusejnovic a PR has been published for this issue now.
Please test #2467 with your recordings and see if it fixes the huge files problem.

@ihusejnovic
Copy link
Contributor

@ihusejnovic a PR has been published for this issue now.
Please test #2467 with your recordings and see if it fixes the huge files problem.

Hey @atoppi, it's working very well. All files with a problematic timestamp are successfully converted. I will use this branch in production from Monday and let you know if I notice any issues. Thank you!

@lminiero
Copy link
Member

lminiero commented Dec 7, 2020

Thanks for the feedback @ihusejnovic, we'll merge then 👍
In case you spot issues in production, this can be fixed along the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants