Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling VideoRoom publisher recording in 'configure' request doesn't work #2564

Closed
biodranik opened this issue Feb 17, 2021 · 3 comments
Closed

Comments

@biodranik
Copy link
Contributor

A room in VideoRoom plugin is created without a secret and with record: true (lock_record: true/false doesn't change anything).
A publisher joins the room like in your VideoRoom JS demo, and then sends a configure request with record: false. Supposedly, this publisher's video, audio, and data should not be recorded after that. But it's not the case: the recordings are still saved on the Janus server.

P.S. enable_recording request with record: false works fine

@lminiero
Copy link
Member

Are you using master? This reminds me of #2550 which we fixed already.

@lminiero
Copy link
Member

Just tested and it works as expected. Closing.

@biodranik
Copy link
Contributor Author

@lminiero Yes, I am using the master branch and reproduced it again on the current master. The bug reproduces, if the recording is disabled in the configure request inside createOffer reply, like in your videoroom demo (in publishOwnFeed()).

It works in a separate configure request with record: false at any later time (but empty 8-byte .mjr files are still created in this case).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants