[1.x] Crash when freeing medium msid

[formater]

What version of Janus is this happening on?
Janus version: 1100 (1.1.0)

Have you tested a more recent version of Janus too?
No, because I can't reproduce the crash

gdb backtrace available here:
https://gist.githubusercontent.com/formater/8424e2e88e398cd90120dcf86c48abb4/raw/680ea9eb7db7a37257471bfd410a679f4b627edf/gistfile1.txt

[lminiero]

We'll need many more details than "it crashed". What were you trying to do? What's the scenario? Which plugins? Any useful information? Thanks.

[formater]

Sorry. The only compiled plugin is the sip plugin. The janus gateway is used as webrtc sip gateway.
I don't know what happened during the crash, because that server is in production, multiple people use the service.

It was up an running for months, and this is the first time seg fault happened. Will try to update to latest version, and wait a few more months to see if the issue still exists or not :)

[atoppi]

According to the stack trace it crashed when freeing the medium->msid (line 3872)

janus-gateway/src/janus.c

Lines 3869 to 3879 in 0b5ea05

	if(opusred_pt < 0 && medium != NULL && medium->opusred_pt > 0)
	medium->opusred_pt = 0;
	if(!have_msid) {
	g_free(medium->msid);
	medium->msid = NULL;
	g_free(medium->mstid);
	medium->mstid = NULL;
	}
	/* Check if rid-based simulcasting is available */
	if(!have_rid && medium != NULL) {
	g_free(medium->rid[0]);

The check for medium != NULL is missing in the involved block, I guess we need to address that.

[lminiero]

The check for medium != NULL is missing in the involved block, I guess we need to address that.

Good catch, I'll add it.

[atoppi]

The above commit should fix the issue, please test and check that everything works as expected.