Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meilisearch requires doctrine bundle although the target application doesn't use it #167

Open
aturki opened this issue Feb 13, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@aturki
Copy link

aturki commented Feb 13, 2022

Description
Basically, when an application uses doctrine mongodb odm for instance, installing meilisearch symfony will also install doctrine bundle which is not required by the app.

Expected behavior
Meilisearch bundle should not depend on doctrine-bundle but rely on configuration options to use the right DB

Screenshots or Logs
N/A

Environment (please complete the following information):

  • meilisearch-symfony version: v0.7.1
@brunoocasali brunoocasali added the enhancement New feature or request label Feb 16, 2022
@brunoocasali
Copy link
Member

Hello @aturki thanks for your message!

Currently, we are working with all hands on the upgrade of the integrations to v0.26 of Meilisearch, so I don't have the time to dig into this :/

But if you want, you could provide a PR for that! I'll be happy to approve it 💪

@norkunas
Copy link
Collaborator

norkunas commented Mar 8, 2022

The doctrine bundle dependency could be made as optional in future if #121 will be implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants