Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PHP CS with the PSR standards #260

Open
2 of 6 tasks
brunoocasali opened this issue Jun 12, 2023 · 3 comments
Open
2 of 6 tasks

Use PHP CS with the PSR standards #260

brunoocasali opened this issue Jun 12, 2023 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@brunoocasali
Copy link
Member

brunoocasali commented Jun 12, 2023

We should introduce stricter rules to maintain this repository and avoid "I think/I like" kind of decisions.

Maybe not all the standards we will have to be compliant https://www.php-fig.org/psr/.

I propose to adopt these standards:

  • 1
  • 3
  • 4
  • 7
  • 18

Also, we should make it automated from the CI standing point.

  • Add the PSR check to the CI.
@brunoocasali brunoocasali added enhancement New feature or request good first issue Good for newcomers labels Jun 12, 2023
@94noni
Copy link
Contributor

94noni commented Jun 25, 2023

This could be great to have indeed, before releasing v1 perhaps ( ref #265 )

@brunoocasali
Copy link
Member Author

I would appreciate it if someone could provide a PR for that!

@norkunas
Copy link
Collaborator

  • For PSR1 - I'd say to stick to Symfony CS as this is a bundle for Symfony :)
  • PSR3 - currently this bundle does not log anything, but as most Symfony setups are using Monolog which is PSR3 compatible, so there are no problems I think to use it if needed.
  • We already follow PSR4 with composer.
  • PSR7/18 - used in meilisearch/meilisearch-php
  • PSR15 is not needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants