Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CumulativeTimeline object doesn't have all the info available in the API #434

Open
JasonMendoza2008 opened this issue Dec 3, 2022 · 2 comments
Open

CumulativeTimeline object doesn't have all the info available in the API #434

JasonMendoza2008 opened this issue Dec 3, 2022 · 2 comments
Labels
help wanted

Comments

@JasonMendoza2008
Copy link

JasonMendoza2008 commented Dec 3, 2022 •
edited
Loading

Accessing a ParticipantState in a CumulativeTimeline object (i.e. at a particular timestamp) doesn't fetch all the info available by the API.

For example, there is no attribute champion stats with ability haste, ability power, etc ...

This is however available on Riot's API:
image
@jjmaldonis
Copy link
Member

Feel free to submit a PR for this.

@JasonMendoza2008
Copy link
Author

JasonMendoza2008 commented Dec 11, 2022 •
edited
Loading

I'll try after Riot fixes the timeline on their end (cf. this issue)!

@JasonMendoza2008 JasonMendoza2008 changed the title CumulativeTimeline object doesn't have all the info available by the API CumulativeTimeline object doesn't have all the info available in the API Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jjmaldonis @JasonMendoza2008