get_account does not allow you to set a region

[lbkulinski]

Hello.

I am experimenting with Cassiopeia and found a potential bug with get_account:

import os

import cassiopeia as cass
from fastapi import FastAPI

api_key = os.environ.get('RIOT_API_KEY')

cass.set_riot_api_key(api_key)

app = FastAPI()


@app.get("/api/lol/me")
async def root():
    account = cass.get_account(name='lbku', tagline='lbku')

    return {
        "account": account.to_dict()
    }

When I hit the endpoint, I get the following error:

TypeError: __get_query_from_kwargs__() missing 1 required keyword-only argument: 'region'

If I try to specify the region via cass.get_account(name='lbku', tagline='lbku', region='NA'), I also get an error:

TypeError: get_account() got an unexpected keyword argument 'region'

Thanks,
Logan

[66Omar]

Hello, @jjmaldonis,
Your last commit says WIP, are you currently working on this update? I managed to fix this locally but still haven't tested the rest of the functionality, if there are no pending changes on your side, I can create a PR hopefully by the end of the day