Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Todos: #35

Open
17 of 19 tasks
karink520 opened this issue Mar 4, 2021 · 4 comments
Open
17 of 19 tasks

Todos: #35

karink520 opened this issue Mar 4, 2021 · 4 comments

Comments

@karink520
Copy link
Collaborator

karink520 commented Mar 4, 2021

If you want to tackle any of these, just reply below, and I'll mark that you're on it!

  • additional test coverage - Gabe and Karin
  • legend for color in precinct_level_plot Gabe
  • show examples of how to set sampling parameters (number of draws, tuning samples, etc....) in notebooks Karin
  • add more exposition in notebooks to make them more beginner-friendly - Karin
  • truncated normal - Karin (implemented a version with pymc - can also add one that's closer to king97)
  • add plots and reporting for differences between racial groups (done for 2 x 2, need r x c) Gabe
  • add candidate of interest reporting Amy
  • Make rbyc model take precinct_names again Karin
  • Generalize plot_precinct_scatterplot to work with 2x2 Karin
  • Prettify plots Gabe
  • Q& G - Karin
  • re-enable alerts for wakefield method Karin
  • Compare to eiPack Gabe, Amy, Karin
  • revise JOSS draft - especially need revisions/feedback on discussion of existing R packages https://github.com/mggg/ecological-inference/tree/paper/paper
  • Make precinct-level kdes plottable by candidate OR group
  • Add example of r by c precinct-level plots to notebook(s)
  • Add example of histogram option of precinct-level plot to notebook(s)

  • Generalize 2x2 plotting functions plot_precincts, plot_conf_or_credible_interval to RxC Gabe
  • Try on Texas data, maybe w/ pickling Gabe
@gabeschoenbach
Copy link
Contributor

I can also take the color legend in precinct_level_plot and adding plots / reporting differences between racial groups for RxC

@karink520
Copy link
Collaborator Author

Amazing! TwoByTwoEIBaseBayes.polarization_report(), TwoByTwoEIBaseBayes._calculate_polarization(), TwoByTwoEIBaseBayes.plot_polarization_kde() what's implemented in the 2x2 case (that last one uses plot_utils.plot_polarization_kde() ), added and merged today, with examples uses in santa_clara_demo.ipynb (look for the green kdes).

@gabeschoenbach
Copy link
Contributor

FYI, added a TODO about generalizing the plotting functions

@bblpo
Copy link

bblpo commented May 4, 2021

Great contribution to many fields. Thanks to your hard work.

One thing that may be more useful to do is to make covariates an option for 2x2. See the last example from the original post: https://gist.github.com/ColCarroll/9fb0e6714dc0369acf6549cededcc875

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants