Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Multiple sets of control buttons #20

Open
lvmajor opened this issue Aug 8, 2018 · 6 comments
Open

Feature request: Multiple sets of control buttons #20

lvmajor opened this issue Aug 8, 2018 · 6 comments

Comments

@lvmajor
Copy link
Contributor

lvmajor commented Aug 8, 2018

Someone asked me if it could be possible to add two sets of buttons for controlling the form process (next/prev buttons)

After a quick look I wondered if it could be done simply by removing the ".first()" call here

What do you think?

@lvmajor lvmajor changed the title Feature request Feature request: Multiple sets of control buttons Aug 8, 2018
@lvmajor
Copy link
Contributor Author

lvmajor commented Aug 8, 2018

Just tested it and it works fine.

Edit: There seems to be a bug causing validation of next step when using the "submit/enter" key on keyboard. I will try to find where it comes from.

@mgildea
Copy link
Owner

mgildea commented Aug 8, 2018

so just for my own understanding...a form could have 2 "next" buttons that act identically (for instance one on the top of the form one on the bottom)?

@lvmajor
Copy link
Contributor Author

lvmajor commented Aug 8, 2018

Exactly, for cases when the form is long enough to have scrolling required in a single step.

@lvmajor
Copy link
Contributor Author

lvmajor commented Aug 8, 2018

Okay so the problem is obviously caused by the fact that my first attempt (removing the .first()) call when finding the navigation, did register both and hence there are two handlers created.

@lvmajor
Copy link
Contributor Author

lvmajor commented Aug 8, 2018

Okay found a workaround, by only using the first registered button when using the key '13' (enter). Don't know if that's optimal though...

Do you think that would be useful/ a potential use case worthy of PR?

@godwindaniel101
Copy link

can i please get a sample on how to use this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants