Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SPOTIFY_LIMIT configurable #115

Open
jankei83 opened this issue Feb 29, 2024 · 3 comments
Open

Make SPOTIFY_LIMIT configurable #115

jankei83 opened this issue Feb 29, 2024 · 3 comments

Comments

@jankei83
Copy link

It would be nice If the UI would give a configuration option for the SPOTIFY_LIMIT parameter.

@michaelherger
Copy link
Owner

That constant is there to protect the application from excessive use: as we can only get 50 items per request, fetching thousands of items results in many requests being sent in a very short period of time. Services usually don't like that and would start blocking requests. As this could potentially impact other Spotty users (Spotify isn't clear about how they count the hit rate), I implemented this upper boundary.

That said: it's always good to know how people are using the plugin. Where do you run into limitations?

@jankei83
Copy link
Author

jankei83 commented Mar 1, 2024

If I search for radio dramas Like "the three ???" there are more than 100 episodes to choose from. Especially my kids would like to choose from all available episodes.

@michaelherger
Copy link
Owner

But you can't listen to the "Drei ???" using search anyway, as that would mess up the order in which the chapters of a story are played? My kids quickly favorited the artist, and started from there.

BTW: SPOTIFY_LIMIT cannot be changed, as that's the maximum page size Spotify would accept. There are other limits, which increase the overall maximum to higher numbers, but not all requests use higher values. I guess that I stuck with lower limits for search, as I would never scroll through search results beyond the first page.

Is the search function the only one where you'd like to up that limit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants