Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading to Magick.Net 13.7.0 breaks ZXing.Magick #571

Closed
flytzen opened this issue May 9, 2024 · 1 comment
Closed

Upgrading to Magick.Net 13.7.0 breaks ZXing.Magick #571

flytzen opened this issue May 9, 2024 · 1 comment

Comments

@flytzen
Copy link

flytzen commented May 9, 2024

The ZXing.Magick binding references Magick.Net.Core vs 12.3.0.

Consumers of ZXing.Magick have to reference Magick.Net themselves (which is a good thing). However, MagickFormat is an enum in Magick.Net.Core and it was changed in Magick.Net v 13.7.0.

This line:

return src.ToByteArray(MagickFormat.Gray);

uses MagickFormat.Gray which has a value of 83 in Magick.Net 13.6.0 and earlier. However, in Magick.Net 13.7.0, 83 equals Gradient.

So, when a consumer of ZXing.Magick upgrades Magick.Net to 13.7.0, it will break ZXing.Magick.

The easiest fix for ZXing would be to upgrade to Magick.Net 13.7.0.

See also

@micjahn
Copy link
Owner

micjahn commented May 31, 2024

Version 0.16.14 of the binding package is pushed to nuget.org. That version is built against version 13.8.0 of Magick.Net.

@micjahn micjahn closed this as completed May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants