Support for --target ES2018

[mhegazy]

As TC39 gets ready to finalize ES2018, we should allow pass through for some transformation now only enabled under --target ESNext, here is the list:

Disable transforms for:

• Rest/Spread Properties
• async generators/for await ... of

We also need some new lib definitions:

• Promise finally (feat(es2018): add definition for Promise.prototype.finally #20411)

The support for --target ES2018 was added in #20385

[mhegazy]

// CC: @bterlson

[mhegazy]

// CC: @benbraou

[bterlson]

Just keep in mind that until a proposal shows up here it's not on the train for 2018.

[dinoboff]

Promise.prototype.finally, rest/spread properties and async iterable made it. Optional catch binding didn't.

[falsandtru]

@mhegazy optional catch binding is still stage 3 (https://github.com/tc39/proposals) and browserify can't compile it. This transform should be kept with es2018.

[DanielRosenwasser]

@falsandtru I've removed * [ ] optional catch binding

[falsandtru]

Thanks!

[LinusU]

Is there any progress on this?

Node.js 10.0.0 now supports 100% of ES2018, but only 8% of ESNEXT. So when targeting Node.js 10.x I would like to use e.g. native async iterators.

Using tsc --target es2018 --lib es2018 file.ts doesn't work for async iterators though. You need to add ,esnext.asynciterables to --lib, and target esnext instead, however doing this would then potentially enable and emit things that aren't supported on Node.js 10.x.

Would love to contribute PRs if there is a clear path forward 🙌

[mhegazy]

A PR would be appreciated. we need to split the transforms to their own file, and pipe the target flag through.

[LinusU]

Haven't worked with the TS code base before, but would be happy to start!

If you have it in your head, some quick links to which files should be changed would be very much appreciated ❤️

[mhegazy]

here is the PR that added ES2017 target, you can use it as a reference: #11407

[Kingwl]

and another feature: #23801 could(maybe) split too

[wolfy1339]

Now that ES2019 is around the corner, it would be a good time for this to be worked on, heck someone made a PR for ES2019 already.