Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive? Ensure elements that have scrollable content are accessible by keyboard #7338

Open
jzazo opened this issue May 18, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@jzazo
Copy link

jzazo commented May 18, 2024

Describe the bug

I am running the accessibility report extension and I get flagged an error: scrollable-region-focusable: Elements with scrollable content must be accessible by keyboard. It affects the search box, enabled via plugin.

Path: .md-search__scrollwrap

Snippet:
- <div class="md-search__scrollwrap"> <div class="md-search-result" data-md-component="search-result">
- <div class="md-search-result__meta">Type to start searching</div> <ol class="md-search-result__list" role="presentation"></ol> </div> 

Fix ONE of the following:
- Element should have focusable content
- Element should be focusable

Adding a tabindex="0" to the div section <div class="md-search__scrollwrap"> removes the error.

However, I created this issue in the material-mkdocs project and you can navigate search results with the keyboard, and the author claims that the flag is a false positive.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://microsoft.github.io/rats/
  2. Run the accessibility-insights-web extension. The error relates to the search box. If you search commands you can scroll through results, so the error is probably a false positive.

Expected behavior

If this is a false positive, an error should not be flagged.

Screenshots

Screenshot 2024-05-18 145934
Screenshot 2024-05-18 145955

Context (please complete the following information)

Are you willing to submit a PR?

No.

Did you search for similar existing issues?

Yes.

@jzazo jzazo added the bug Something isn't working label May 18, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the status: new This issue is new and requires triage by DRI. label May 18, 2024
@v-viyada v-viyada added status: needs investigation This issue requires investigation (PM, Design, or SWE) by the Accessibility Insights team. and removed status: new This issue is new and requires triage by DRI. labels May 21, 2024
Copy link
Contributor

This issue requires additional investigation by the Accessibility Insights team. When the issue is ready to be triaged again, we will update the issue with the investigation result and add "status: ready for triage". Thank you for contributing to Accessibility Insights!

@v-viyada
Copy link
Contributor

@jzazo We have opened dequelabs/axe-core#4470 for axe-core. We will update in the extension once we have fix from upstream. Thanks

@v-viyada v-viyada removed the status: needs investigation This issue requires investigation (PM, Design, or SWE) by the Accessibility Insights team. label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Accepted - vendor
Development

No branches or pull requests

2 participants