Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MenuFlyouts appear darker with WInUI Theming #4137

Closed
vitordelucca opened this issue Feb 9, 2021 · 3 comments
Closed

MenuFlyouts appear darker with WInUI Theming #4137

vitordelucca opened this issue Feb 9, 2021 · 3 comments
Labels
area-Flyouts area-Shadows team-Rendering Issue for the Rendering team

Comments

@vitordelucca
Copy link

vitordelucca commented Feb 9, 2021 •
edited
Loading

MenuFlyouts appears randomly darker when using WinUI theming with OS/SDK applied ThemeShadow. Happens on Photos, Unigram, and several other apps.

Steps to reproduce the bug

  1. Open an app like Photos
  2. Click on '...' and randomly it happens
    image
  3. When this happens, ThemeShadow remains active if you alternate between windows. Do a Alt+tab and you'll see
    image

Expected behavior
image

Version Info
I checked with WinUI 2.4, WinUI 2.5. Windows 19042. UWP targeting Windows SDK 18362 and 19041 and could repro.

My guess: SDK/OS applying ThemeShadow on wrong z-order, because Flyout xaml resources theming changes with WinUI.

My guess to fix (still need to check): WinUI should probably make use of ThemeShadow itself on it's own theming resources, and replace SDK shadow styling.
@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Feb 9, 2021
@mdtauk
Copy link
Contributor

mdtauk commented Feb 9, 2021

@karenbtlai #4079

@StephenLPeters StephenLPeters added area-Flyouts area-Shadows team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Feb 10, 2021
@StephenLPeters
Copy link
Contributor

@kmelmon FYI

@StephenLPeters StephenLPeters added team-Rendering Issue for the Rendering team and removed team-Controls Issue for the Controls team labels Feb 10, 2021
@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Feb 10, 2021
@pratikone
Copy link
Contributor

can you check if it still gets reproduced ? feel free to open this issue again if it does.

@ghost ghost removed the needs-triage Issue needs to be triaged by the area owners label Oct 14, 2022
@github-actions github-actions bot mentioned this issue Jan 11, 2024
Open
@github-actions github-actions bot mentioned this issue May 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-Flyouts area-Shadows team-Rendering Issue for the Rendering team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pratikone @mdtauk @StephenLPeters @vitordelucca