-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NavigationView
selection indicator sometimes stays in incorrect location
#6837
Comments
We have already fixed the problem in Uno Platform via unoplatform/uno#8272, so I can replicate the same fix here as well - please assign this to me 👍 |
@MartinZikmund thanks for finding a fix! Assigned the issue to you. |
I see a similar problem in the current WindowsAppSDK. Is the fix going to be released? |
@sjb-sjb I think the fix is ready to be merged, just needs the approval stamp 👍 |
@MartinZikmund thanks. So I guess it has been ready to go for 9 months then. I don’t know what the process is for getting this approved and included in the release… |
@SavoySchuler @gabbybilka @michael-hawker , can you please help get the PR approved? |
@bpulliam Can you take a look? |
I am unable to repro this issue in the new WinUI 3 Gallery. There were fixes made to the selection indicator behavior which may have been what fixed the scenario in question. @sjb-sjb Would you be able to provide some more info about how the problem is manifesting for you? This potentially could help us make a more targeted fix. |
On recent versions of WindowsAppSDK, I have intermittent cases where top navigation seems to occur twice. In my case the nav view is being used to navigate pages on a Frame. In some cases selecting a new top item results in the old page leaving, coming back, then leaving again. I do not have details or a repro because it is intermittent. It seems likely to me that this is a problem with event timing or something along those lines rather than the selection indicator itself. Suggest we take the fix provided. |
This issue does sound unrelated to the selection indicator animation. It would be helpful if you open a separate bug for this, so we don't confuse the two. |
Describe the bug
We noticed this problem in our ported version in Uno Platform (specifically unoplatform/uno#5704). This problem occurs when
NavigationView
is in "minimal" mode and closes after item selection. In such case the selection indicator in some cases does not correctly move to the newly selected (and collapsed) item. It becomes even more visible for nested hierarchical items.Steps to reproduce the bug
This is just one example of the behaviors that occur, there are others as well. Focus on the selection indicator on the edge of the GIF (sorry for the cutoff)
Expected behavior
The selection indicator should always show which parent is "selected"
Screenshots
No response
NuGet package version
WinUI 3 - Windows App SDK 1.0
Windows app type
Device form factor
Desktop
Windows version
Windows 11 (21H2): Build 22000
Additional context
No response
The text was updated successfully, but these errors were encountered: