Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OverlappedPresenter.IsMaximizable should disable extended title bar double clicking #8846

Closed
dongle-the-gadget opened this issue Sep 3, 2023 · 3 comments
Labels
area-AppWindow team-CompInput Issue for IXP (Composition, Input) team

Comments

@dongle-the-gadget
Copy link

dongle-the-gadget commented Sep 3, 2023

Describe the bug

Currently, OverlappedPresenter.IsMaximizable would disable the maximize button, but it doesn't disable extended title bar (AppWindowTitleBar.ExtendsContentIntoTitleBar) double-clicking to maximize, which would result in the window hiding the taskbar.

Steps to reproduce the bug

Add this code, double click the window title bar and observe the window being maximized, hiding the taskbar.

// Initialize _appWindow.

// Enable extended title bar.
_appWindow.TitleBar.ExtendsContentIntoTitleBar = true;

// Set maximizable to false
OverlappedPresenter presenter = _appWindow.Presenter as OverlappedPresenter;
presenter.IsMaximizable = false;

Expected behavior

The window shouldn't maximize when the user double clicks the title bar and IsMaximizable is false.

Screenshots

No response

NuGet package version

Windows App SDK 1.4.0: 1.4.230822000

Packaging type

Unpackaged

Windows version

Insider Build (xxxxx)

IDE

Visual Studio 2022-preview

Additional context

No response

@BreeceW
Copy link
Contributor

BreeceW commented Sep 3, 2023

Regarding “Might require AppWindowTitleBar.ExtendsContentIntoTitleBar?”

If the app does not use extends content into title bar, this issue seems to reproduce only if the XAML Hot Reload toolbar is enabled and showing (i.e., debugging in Visual Studio).
XAML Hot Reload toolbar and default Windows title bar

However, if the app is extended into title bar, then this issue does reproduce regardless of the Hot Reload toolbar and amounts to a usability issue.

@dongle-the-gadget
Copy link
Author

I'll update the issue, thanks

@dongle-the-gadget dongle-the-gadget changed the title OverlappedPresenter.IsMaximizable should disable title bar double clicking OverlappedPresenter.IsMaximizable should disable extended title bar double clicking Sep 3, 2023
@bpulliam bpulliam transferred this issue from microsoft/WindowsAppSDK Sep 7, 2023
@bpulliam bpulliam added area-AppWindow team-CompInput Issue for IXP (Composition, Input) team labels Sep 7, 2023
@bpulliam
Copy link
Contributor

Duplicate of #8666

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-AppWindow team-CompInput Issue for IXP (Composition, Input) team
Projects
None yet
Development

No branches or pull requests

3 participants