Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use IR in the optimizer #1701

Open
Tracked by #129274
justinchuby opened this issue Jun 22, 2024 · 2 comments
Open
Tracked by #129274

Use IR in the optimizer #1701

justinchuby opened this issue Jun 22, 2024 · 2 comments

Comments

@justinchuby
Copy link
Contributor

justinchuby commented Jun 22, 2024

And improve robustness so it is reliable enough to be turned on by default.

@justinchuby
Copy link
Contributor Author

justinchuby commented Jun 25, 2024

The ExternalTensor support in the IR is working only when code is launched at the same directory as the model file. Aka. we read the external data file using relative paths. This is because when a model is loaded as a proto, its path information is lost to the IR. We need to design a way (e.g. pass in base path when deserializing) to handle when the model file is somewhere else.

This is relevant because I assume the optimizer will sometimes fold external tensors. Some examples may include Transpose(x) and element wise computation, casting, etc.

@gramalingam
Copy link
Collaborator

Related: #1436

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants