[5.0.0-beta] first sync has no packageHash in query

[lisong]

Steps to Reproduce

1. install demo app
2. click sync
3. it's download full package in first sync, it should show "App up to date"

Expected Behavior

/updateCheck?deploymentKey=BPPCDEeergFkpHur4YNXCjqXVjR6qLF160UDg&appVersion=2.0.0&packageHash=16bd9232a31ecdc4cfd01a660dbd81e28b3e5709a1505daf429028c5ec49fe9f&isCompanion=&label=&clientUniqueId=319708d364f191f1

Actual Behavior

What actually happens?

/updateCheck?deploymentKey=BPPCDEeergFkpHur4YNXCjqXVjR6qLF160UDg&appVersion=2.0.0&packageHash=&isCompanion=&label=&clientUniqueId=319708d364f191f1

Environment

• react-native-code-push version: 5.0.0-beta
• react-native version: 0.47.1
• iOS/Android/Windows version: Android
• Does this reproduce on a debug build or release build? both
• Does this reproduce on a simulator, or only on a physical device? both

[sergey-akhalkov]

Hi @lisong, thanks for reaching us. Yeah, that's known "issue" and we've tried to fix it but reverted our changes due to the following issues: #906, #910

We've already deployed server-side changes needed to fix the issue, so you could try to perform this changes and verify if it works for you. We also gonna test it and in case everything works well - we'll create PR.

[lisong]

OK

[lisong]

why v5.3.2 not fix

  let queryPackage;
  if (localPackage) {
    queryPackage = localPackage;
  } else {
    queryPackage = { appVersion: config.appVersion };
    if (Platform.OS === "ios" && config.packageHash) {
      queryPackage.packageHash = config.packageHash;
    }
  }

[lisong]

i read the code. it could not solve this problem in client. it's complicate. diff update way need copy current package to generate new packages, but android resource it in apk. could we contact react-native team, proposal storage bundle and res in other place ?