-
Notifications
You must be signed in to change notification settings - Fork 28.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[theming][editor] support selection foreground color #10622
Comments
selectionForeground would be very difficult implement given that in our editor selection and text are two different layers. @alexandrudima Alex, correct me if I lie. |
This is one of a few issues that make themes converted from sublime text look bad (another example #3429). The majority of our themes are converted from sublime or atom themes so shouldn't we provide similar support to those editors? |
@aeschli is correct. The text and the selection are rendered as different layers. When the selection changes, the text is not repainted. This was implemented 5 years ago with performance in mind and without having |
Surely it would be ideal if we fully support all the various text mate theme properties, but there will always be differences and features we don't or can't support. Closing won't fix given there's no plan on changing the current editor implementation in respect of keeping the selection layer separate from the text later. |
Any reason this can't just be done using an |
Oh yeah, it's not native selection so |
It's difficult to read selected text when the theme is designed to change the foreground color:
The text was updated successfully, but these errors were encountered: