Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope background color support for themes #16461

Closed
ghost opened this issue Dec 4, 2016 · 5 comments
Closed

Scope background color support for themes #16461

ghost opened this issue Dec 4, 2016 · 5 comments
Labels
editor-core Editor basic functionality feature-request Request for new features or functionality
Milestone

Comments

@ghost
Copy link

ghost commented Dec 4, 2016

  • VSCode Version: 1.7.2
  • OS Version: macOS 10.12.1

Steps to Reproduce:

  1. ext install theme-a
  2. Change theme

screen shot 2016-12-04 at 18 05 37


so

screen shot 2016-12-04 at 18 03 30


but

screen shot 2016-12-04 at 18 04 20

@chrmarti
Copy link
Contributor

chrmarti commented Dec 5, 2016

@flagello Not sure I follow, what should the background color be scoped to?

@ghost
Copy link
Author

ghost commented Dec 5, 2016

Sorry for the lack of clarity @chrmarti. I meant that a background color is not applied to the scope despite being specified.

VS Code
screen shot 2016-12-04 at 18 05 37

TextMate 2
screen shot 2016-12-05 at 15 45 30

@alexdima alexdima added feature-request Request for new features or functionality editor-core Editor basic functionality labels Dec 12, 2016
@alexdima alexdima added this to the Backlog milestone Dec 12, 2016
@alexdima alexdima removed their assignment Dec 12, 2016
@aziz
Copy link

aziz commented Feb 8, 2017

I have this issue as well. vs-code basically ignores all background color definitions for the scopes in tmTheme file and only applies the global background color.
This is extremely useful to make themes that get different background colors for different syntaxes.
for example:

  • marking the code section in a markdown
  • changing the background color of the style and script tags inside an HTML document
  • change the background color of embedded code inside HTML documents for templating libraries in PHP, Ruby and Python
  • having syntax specific background colors. you might want light background color for markdown but dark background color for all the code.

@auchenberg
Copy link
Contributor

Duplicate, #3429

@aeschli
Copy link
Contributor

aeschli commented Aug 18, 2017

closing as duplicate of #3429, thanks @auchenberg!

@aeschli aeschli closed this as completed Aug 18, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-core Editor basic functionality feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

5 participants