Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No support for tmTheme background colors #18542

Closed
pouyakary opened this issue Jan 14, 2017 · 2 comments
Closed

No support for tmTheme background colors #18542

pouyakary opened this issue Jan 14, 2017 · 2 comments
Assignees
Labels
themes Color theme issues

Comments

@pouyakary
Copy link
Contributor

pouyakary commented Jan 14, 2017

  • VSCode Version: All versions
  • OS Version: macOS Sierra

.tmTheme definitions can have background colors specified with background keys such:

<!-- Number -->
<dict>
    <key>scope</key>
    <string>constant.numeric</string>
    <key>settings</key>
    <dict>
        <key>foreground</key>
        <string>#8fc2bbbb</string>
        <key>background</key>
        <string>#8fc2bb0f</string>
    </dict>
</dict>

and vscode provides on such support for this. A theme like NeonGlow that normally looks like this:

screen shot 2017-01-14 at 11 33 46 am

In vscode looks like:

screen shot 2017-01-14 at 11 33 02 am

@dbaeumer dbaeumer added the themes Color theme issues label Jan 16, 2017
@aeschli
Copy link
Contributor

aeschli commented Jan 19, 2017

duplicate of #3429

@aeschli aeschli closed this as completed Jan 19, 2017
@pouyakary
Copy link
Contributor Author

@aeschli nice...

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
themes Color theme issues
Projects
None yet
Development

No branches or pull requests

3 participants