Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classes for styling - incompatible changes. #18786

Closed
Webtakeme opened this issue Jan 19, 2017 · 2 comments
Closed

Classes for styling - incompatible changes. #18786

Webtakeme opened this issue Jan 19, 2017 · 2 comments
Assignees
Labels
*question Issue represents a question, should be posted to StackOverflow (VS Code)

Comments

@Webtakeme
Copy link

  • VSCode Version: 1.9.x (Insiders) January 2017
  • OS Version: all os

Steps to Reproduce:

  1. Update VSCode to January 2017 build (insiders). All previous build is fine.
  2. Open "help"-->"Toggle developer tools"-->inspect different type of rendered code element (for example in javascript - const, let, class, import, function, block, expression ... etc). Like "<span class="token js meta var expr storage type">const</span>".

Before january build each peace of code (each <div>) in vscode had special class on rendered element. There was special class for each type of code element (constants, imports, object literal, keyword, variable, assignment, definition, brace, brace round, storage, punctuation, method, declaration ... ... ....). It system give us (developer and user) huge possibility to customize our code (like extension "vscode-custom-css") and make themes for vscode. One of great advantages of vscode - is excellent font rendering.

The PROBLEM is now (from january build) all this system is broken. Instead of huge additional classes we got only small piece of classes:

.mtk1 { color: #B3B3D4; }
.mtk2 { color: #1D1D26; }
.mtk3 { color: #504E6E; }
.mtk4 { color: #CC66FF; }
.mtk5 { color: #00D364; }
.mtk6 { color: #FF3399; }
.mtk7 { color: #F8F8F0; }
.mtk8 { color: #00BFFF; }
.mtk9 { color: #FFCC66; }
.mtk10 { color: #00CED1; }
.mtki { font-style: italic; }
.mtkb { font-weight: bold; }
.mtku { text-decoration: underline; }

and that's all we got now (no all the stuff that I describe before). See attached photo for compare "before" and "after".
13 classes instead of about 40 and they combination 👎

I really understand that in this way vscode creators make renders much more faster in the editor....
and some times we will have breaking changes... but you remove all this class system (EXTREMELY REDUCE CUSTOMIZATION POSSIBILITY )

PLEASE BRING BACK CLASS SYSTEM !!! 👍

Old excellent "class system":

before-changes-with-class-system

New poor classes:

after update-no-classes

Feeling like moved from IDE (IntelliJ IDEA‎, Visual Studio ....) to notepad 👎

Code before update (each type of code properly colorized) + additional font-family for some type of code.

before-update

Code after update (poor colorization - half of code in the same color). Greeting for people with bad vision :(

after-update

PLEASE BRING BACK CLASS SYSTEM !!! 👍

@joshwiens
Copy link

joshwiens commented Jan 19, 2017

#18357
#17933

All be it exceptionally frustrating for anyone that put time into getting a theme created & dialed in given it isn't documented and has to be inspected which makes it inexplicably tedious

@alexdima
Copy link
Member

Please read #18357 (comment) and also follow the links in there.

It explains at length everything.

@alexdima alexdima added the *question Issue represents a question, should be posted to StackOverflow (VS Code) label Jan 20, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*question Issue represents a question, should be posted to StackOverflow (VS Code)
Projects
None yet
Development

No branches or pull requests

4 participants