Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light color theme showing white for some elements #2158

Closed
jonvuri opened this issue Jan 21, 2016 · 2 comments
Closed

Light color theme showing white for some elements #2158

jonvuri opened this issue Jan 21, 2016 · 2 comments
Assignees
Labels
themes Color theme issues

Comments

@jonvuri
Copy link

jonvuri commented Jan 21, 2016

I'm not sure if this is an issue with Vscode or with the Tomorrow color theme itself, but there's no repo or issue tracker listed anywhere for the extension, so...

The light version in this color theme:

https://marketplace.visualstudio.com/items/ms-vscode.Theme-TomorrowKit

Results in some code elements being white on the white background:

screen shot 2016-01-21 at 14 44 16

In this case, the commas and colons in this JSON file.

@Tyriar
Copy link
Member

Tyriar commented Jan 21, 2016

Looks like an issue with the tomorrow theme. This is the rule that is coloring it, nothing should be colored white on a white background:

.monaco-editor.vs.ms-vscode-Theme-TomorrowKit-themes-Tomorrow-tmTheme .token.meta.separator {
    color: rgba(255, 255, 255, 1);
}

@aeschli
Copy link
Contributor

aeschli commented Jan 22, 2016

This issue was moved to microsoft/vscode-themes#2

@aeschli aeschli closed this as completed Jan 22, 2016
@aeschli aeschli removed the bug Issue identified by VS Code Team member as probable bug label Jan 28, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
themes Color theme issues
Projects
None yet
Development

No branches or pull requests

4 participants