Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to disable textual completion prosals for an position or language #2496

Closed
aeschli opened this issue Jan 28, 2016 · 2 comments
Closed
Assignees
Labels
api feature-request Request for new features or functionality verified Verification succeeded
Milestone

Comments

@aeschli
Copy link
Contributor

aeschli commented Jan 28, 2016

At the moment when none of the contributed completion processors returns any proposals, the textual completion processor starts adding proposals.
That's fine for languages where we have no sophisticated completion processor, but looks bad for languages that pretend to have a 'smart' completion processor.

@jrieken
Copy link
Member

jrieken commented Jan 28, 2016

That's fine for languages where we have no sophisticated completion processor, but looks bad for languages that pretend to have a 'smart' completion processor.

Well, I love it in TypeScript even tho it's smart. Textual completion proposes variable names, completes in comments and in strings, etc. Such a flag should only be used when having great confidence, like in member completion.

One option will be to add a isComplete flag to the CompletionList tho that's a big hammer. I can image some smart extension wanting to add quick fixes as completion proposals - like add method when doing unsuccessful member completion. We have to make sure we don't disable such scenarios with such a hammer.

@jrieken
Copy link
Member

jrieken commented Mar 8, 2016

closing as duplicate of #1657

@jrieken jrieken closed this as completed Mar 8, 2016
@jrieken jrieken assigned aeschli and unassigned jrieken Mar 23, 2016
@aeschli aeschli added the verified Verification succeeded label Mar 23, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api feature-request Request for new features or functionality verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants