Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css] Support auto-complete of gradient function parameters like currently do for rgb/hsl #605

Closed
dstorey opened this issue Nov 25, 2015 · 3 comments
Assignees
Labels
css-less-scss Issues and items concerning CSS,Less,SCSS styling feature-request Request for new features or functionality languages-basic Basic language support issues *out-of-scope Posted issue is not in scope of VS Code
Milestone

Comments

@dstorey
Copy link
Member

dstorey commented Nov 25, 2015

The colour functions in CSS currently prefill the parameters and allow you to tab through the values. Similarly it would be nice to support that for the 4 gradient functions, especially as the syntax is some times hard to remember (not helped by the fact it has changed so many times). Currently it just supplies empty ().

The colour functions are set up in languagefacts, while the gradients are just standard property values in the XML file.

@dstorey
Copy link
Member Author

dstorey commented Nov 25, 2015

…this is complicated by the fact that while all values are required in RGB()/HSLA(), in gradients, some are optional, and there can be multiple colour stops added.

@aeschli aeschli added the feature-request Request for new features or functionality label Nov 25, 2015
@aeschli
Copy link
Contributor

aeschli commented Nov 25, 2015

+1 for adding the gradient functions. It should be easy to add following the approach we currently have. Check out colorFunctions in /src/vs/languages/css/common/services/intelliSense.ts as well as
/src/vs/languages/sass/common/services/intelliSense.ts

@aeschli aeschli changed the title Support auto-complete of gradient function parameters like currently do for rgb/hsl [css] Support auto-complete of gradient function parameters like currently do for rgb/hsl Nov 25, 2015
@egamma egamma added the languages-basic Basic language support issues label Nov 30, 2015
@aeschli aeschli added the css-less-scss Issues and items concerning CSS,Less,SCSS styling label Nov 30, 2015
@egamma egamma modified the milestone: Backlog Dec 10, 2015
@aeschli aeschli added the *out-of-scope Posted issue is not in scope of VS Code label Nov 20, 2017
@vscodebot
Copy link

vscodebot bot commented Nov 20, 2017

This feature request will not be considered in the next 6-12 months roadmap and has been closed to keep the number of issues we have to maintain manageable. See also our issue reporting guidelines.

Thanks for your understanding and happy coding!

@vscodebot vscodebot bot closed this as completed Nov 20, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
css-less-scss Issues and items concerning CSS,Less,SCSS styling feature-request Request for new features or functionality languages-basic Basic language support issues *out-of-scope Posted issue is not in scope of VS Code
Projects
None yet
Development

No branches or pull requests

4 participants
@egamma @dstorey @aeschli and others