-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Feature]: Have Wingetbot try to match the version formatting #34421
Comments
I've suggested before in an old discussion that the validation pipeline should be able to verify the ARP metadata, and I believe @denelon said they were investigating it (so that getting the data for microsoft/winget-cli#1073 would be entirely automated). I don't know if any more thought has gone into that, but it could help with the latter part of your request. |
We are getting much closer to being able to do this. Internally another team is also working on validation in the Microsoft Store validation flow. We're going to augment their functionality to include support for our scenarios. We will be switching to that validation service and retiring the one we built after we have full parity. It doesn't make sense to have two teams working to solve the same problems. We are hoping it will give us more capacity to continue developing more new features and fixing more bugs. I don't have an ETA for this yet as we're still in the discovery and design phases. It will most likely be a transparent change to the community. We have already included validating "Apps & Features" data in the manifest against what was detected in the validation VM. It will also likely mean the bot will need to be able to submit a subsequent push to the branch it is working on when it creates an initial PR to update the metadata. |
Does this kill the discussion about some of the validation code being open-sourced? (Not the end of the world if it's going to be easier to maintain for you going forward, but it'd be nice to help 😊). |
We're still hoping to open source some of the validation code. The parts that we aren't able to be open source will at least be documented in a way to help understand what check was performed, and the various failure reasons. We had a long arduous path to develop the policies and at least get those specific errors called out. We're hoping to be able to get more granular where we can, and at least make it a bit more transparent. We still suffer from some services that we still must treat as a closed system ourselves. We don't always get informed why something failed, just that it did. Some of those have also been false positives and false negatives which makes things much harder to troubleshoot and be transparent about. |
Description of the new feature/enhancement
This idea is based from these PR's, among others:
I propose that @wingetbot should try to pattern match whatever version it detects to the package version which already exists in the repo. This would allow the bot to be self-correcting in the cases where the tag or published version is of a different string format than the one in ARP.
This may also be something to consider along with microsoft/winget-create#203
Proposed technical implementation details (optional)
I know it would take a lot of work, but it should be possible to do string interpolation like this. Alternatively, if the bot had an environment to install the application and pull directly from ARP, that would avoid the issue entirely.
Examples:
The text was updated successfully, but these errors were encountered: