logger can't be disabled

[buckle2000]

The following code treats logger=False as logger=True.

python-engineio/engineio/client.py

Lines 104 to 114 in a67b3d7

	if not isinstance(logger, bool):
	self.logger = logger
	else:
	self.logger = default_logger
	if not logging.root.handlers and \
	self.logger.level == logging.NOTSET:
	if logger:
	self.logger.setLevel(logging.INFO)
	else:
	self.logger.setLevel(logging.ERROR)
	self.logger.addHandler(logging.StreamHandler())

The docstring says otherwise:

python-engineio/engineio/client.py

Lines 58 to 60 in a67b3d7

	:param logger: To enable logging set to ``True`` or pass a logger object to
	use. To disable logging set to ``False``. The default is
	``False``.

[buckle2000]

This is the same for server of this module and client and server of python-socketio.

A simple work around is to use unittest.mock.Mock

[miguelgrinberg]

Errors cannot be disabled, setting logger to False just silences anything below ERROR level. But you are correct in that the documentation does not explain this, I'll fix it.