Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

socketio_path doesn't handle absolute path #83

Closed
hsmade opened this issue Mar 13, 2017 · 1 comment
Closed

socketio_path doesn't handle absolute path #83

hsmade opened this issue Mar 13, 2017 · 1 comment
Assignees
Labels

Comments

@hsmade
Copy link

hsmade commented Mar 13, 2017

app = web.Application(loop=loop)
sio.attach(app, socketio_path='/ws/socket.io')

Results in:
websocket_1 | INFO:aiohttp.access:172.20.0.10 - - [13/Mar/2017:15:17:31 +0000] "GET /ws/socket.io/?EIO=3&transport=polling&t=Lh8Fkkb HTTP/1.1" 404 14 "-" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/56.0.2924.76 Chrome/56.0.2924.76 Safari/537.36"

I found that, for this to work, I needed to drop the leading '/'. Can you please handle this (probably very common) use case in the code?

@miguelgrinberg
Copy link
Owner

Yeah, I agree, this should work either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants