-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues with updater if ARM filenames have suffix, while x64 filenames don't #114
Comments
+1 on this issue, had it occur when updating IPTVnator. Maybe if instead of globes, matching used regular expressions, we could then negate portions if required? It's nowhere near as clean as the globes, but I could then use |
Hi guys, thanks for the suggestions . I'm currently exploring other options |
While I would appreciate it if regex could be used (given the control you can have), I think @mijorus POV is right. Regex can be daunting and would make the experience too much technical. I think the best option would be to have a field called ignore, where you can put blacklisted strings. In this case, the user could type arm. These keywords would be used as statements to ignore the wildcard check. |
That's not so easy, is it? What if the app has "arm" in the name? I should probably develop some "smart picker" which reads all the available files and picks the appropriate one based on the system architecture |
I know it does. But it shouldn't 🤣 |
You're right. I was thinking for the validation to be done between the two wildcards, but there's no guarantee that the string won't appear before, or that the user will have two wildcards. |
Hi, I'm glad to see that this issue has been identified and is being worked on. Has anyone found a workaround for now or at least a temporary solution to fix this problem? |
Hello. I've encountered an issue with the GitHub updater on a few repos that release their ARM AppImages with suffix, but their x64 AppImages without a suffix; similar to this:
This causes Gear Lever to both incorrectly assume there's an update and potentially download an AppImage for the wrong architecture. This occurs, for example, with Kopia:
I believe the best solution for this would be to first check for URLs where all wildcards (
*
) match:https://github.com/kopia/kopia/releases/download/v*/KopiaUI-*.AppImage
v0.17.0
(with av
) at time of posting*
matches0.17.0
(without thev
)https://github.com/.../v0.17.0/KopiaUI-0.17.0.AppImage
Or, if it doesn't find the file, it proceeds with the previous logic.
The text was updated successfully, but these errors were encountered: