Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minetest.colorspec_to_colorstring used from MT 5.5 #78

Open
dennisjenkins75 opened this issue Jan 23, 2023 · 2 comments
Open

minetest.colorspec_to_colorstring used from MT 5.5 #78

dennisjenkins75 opened this issue Jan 23, 2023 · 2 comments

Comments

@dennisjenkins75
Copy link

Server: MultiCraft 2.0.0 (Linux)
(Hosted on EdgyNet)

Possibly due to commit c46e246 (2022-01-20, ~2d ago). No crash like this seen before in my logs until now. I was not in-game when this happened, and do not yet know what the trigger or repro is.

2023-01-23 02:53:57: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod 'drawers' in callback LuaLBM::trigger(): /home/1hit/worlds/world/worldmods/drawers/lua/helpers.lua:65: attempt to call field 'colorspec_to_colorstring' (a nil value)
2023-01-23 02:53:57: ERROR[Main]: stack traceback:
2023-01-23 02:53:57: ERROR[Main]:       /home/1hit/worlds/world/worldmods/drawers/lua/helpers.lua:65: in function 'tile_to_image'
2023-01-23 02:53:57: ERROR[Main]:       /home/1hit/worlds/world/worldmods/drawers/lua/helpers.lua:83: in function 'get_inv_image'
2023-01-23 02:53:57: ERROR[Main]:       /home/1hit/worlds/world/worldmods/drawers/lua/helpers.lua:184: in function 'spawn_visuals'
2023-01-23 02:53:57: ERROR[Main]:       /home/1hit/worlds/world/worldmods/drawers/lua/visual.lua:461: in function </home/1hit/worlds/world/worldmods/drawers/lua/visual.lua:435>
@dennisjenkins75
Copy link
Author

Now that I checked my logs, this crash is FREQUENT. I will likely rollback this update on my server. Suggest that mod author review the suspect commit.

@OgelGames
Copy link
Contributor

OgelGames commented Jan 23, 2023

MultiCraft doesn't have the function minetest.colorspec_to_colorstring, which was added in Minetest 5.5.0.

But the cause is that commit, because currently drawers's min_minetest_version is 5.0, so that function shouldn't have been used.

min_minetest_version = 5.0

@lnjX lnjX changed the title [BUG] Crash minetest.colorspec_to_colorstring used from MT 5.5 Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants