Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standalone shows still broken #11

Open
mattkemp opened this issue Apr 21, 2022 · 4 comments
Open

Standalone shows still broken #11

mattkemp opened this issue Apr 21, 2022 · 4 comments

Comments

@mattkemp
Copy link

installed dev branch using:

pip3 install git+https://github.com/missionpinball/mpf-ls.git@dev

now have this version:

mpf-language-server     0.55.0.dev1+8.g4d9055d

standalone shows are causing this error:

Internal error while verifying: Failed to split 0 Traceback (most recent call last):
  File "c:\users\matt\mpfenv\lib\site-packages\mpfls\mpf_ls.py", line 1148, in _get_spec
    spec_names = spec_name_str.split(",")
AttributeError: 'int' object has no attribute 'split'

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "c:\users\matt\mpfenv\lib\site-packages\mpfls\mpf_ls.py", line 1355, in lint_internal
    diagnostics = self._walk_diagnostics_root(document, document.config_roundtrip)
  File "c:\users\matt\mpfenv\lib\site-packages\mpfls\mpf_ls.py", line 1045, in _walk_diagnostics_root
    root_spec = self._get_spec(key)
  File "c:\users\matt\mpfenv\lib\site-packages\mpfls\mpf_ls.py", line 1150, in _get_spec
    raise AssertionError("Failed to split {}".format(spec_name_str)) from e
AssertionError: Failed to split 0
mpf-ls(998)
@mattkemp
Copy link
Author

mattkemp commented Apr 21, 2022

a standalone show in my root directory like /shows/flash_red.yaml is fine, but if I copy that same show into a mode's shows directory /modes/modeX/shows/flash_red.yaml it goes red and has the error above.

YAML for flash_red.yaml:

#show_version=5

- time: 0
  lights:
    (led): red
- time: +1
  lights:
    (led): off
- time: +1 #is this necessary?

@jabdoa2
Copy link
Contributor

jabdoa2 commented Apr 21, 2022

yeah it does not currently understand shows. this would be something to add. i think i started this a while ago but did not work on this for at least half a year.

@mattkemp
Copy link
Author

I guess it's not really a high priority as the shows still work.

It seems like it does understand the shows (in the root), it's just a sub directory issue.

@ericselk2018
Copy link

This solves the issue for me: #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants