Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Keyboard Shortcuts Window #639

Closed
gabrbrand opened this issue Apr 30, 2024 · 1 comment · Fixed by #677
Closed

Add Keyboard Shortcuts Window #639

gabrbrand opened this issue Apr 30, 2024 · 1 comment · Fixed by #677
Labels
enhancement New feature or request

Comments

@gabrbrand
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Currently there are some shortcuts like Alt + 1 / 2 most users don't know and therefore don't use.

Describe the solution you'd like
It would be good if there was a window that listed all available shortcuts.

Additional context

using Gtk 4.0;

ShortcutsWindow help_overlay {
  modal: true;

  ShortcutsSection {
    section-name: "shortcuts";
    max-height: 10;

    ShortcutsGroup {
      title: C_("Shortcuts Window", "Window");

      ShortcutsShortcut {
        accelerator: "<Alt>1";
        title: C_("Shortcuts Window", "Show Installed Page");
      }

      ShortcutsShortcut {
        accelerator: "<Alt>2";
        title: C_("Shortcuts Window", "Show Browse Page");
      }
    }

    ShortcutsGroup {
      title: C_("Shortcuts Window", "Screenshot View");

      ShortcutsShortcut {
        accelerator: "<ctrl>plus";
        title: C_("Shortcuts Window", "Zoom In");
      }

      ShortcutsShortcut {
        accelerator: "<ctrl>minus";
        title: C_("Shortcuts Window", "Zoom Out");
      }

      ShortcutsShortcut {
        accelerator: "<ctrl>0";
        title: C_("Shortcuts Window", "Reset Zoom");
      }
    }

    ShortcutsGroup {
      title: C_("Shortcuts Window", "Application");

      ShortcutsShortcut {
        // Needs to be added
        accelerator: "<Primary>question";
        title: C_("Shortcuts Window", "Show Keyboard Shortcuts");
      }

      ShortcutsShortcut {
        accelerator: "<Primary>Q";
        title: C_("Shortcuts Window", "Quit Application");
      }

      ShortcutsShortcut {
        accelerator: "<Primary>W";
        title: C_("Shortcuts Window", "Close Application Window");
      }
    }
  }
}
@oscfdezdz oscfdezdz added the enhancement New feature or request label Apr 30, 2024
@oscfdezdz
Copy link
Collaborator

I agree, I had in a local branch the changes made from a while ago, I've rebased and push them to help-overlay branch but it requires #568 to work in the development version as well.

If you want you can open a merge request to that branch, some of the shortcuts you have proposed are missing and the names and groups are better written, otherwise I'll update it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants