Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SyntaxWarning: "is" with a literal. Did you mean "=="? #21

Closed
mkcn opened this issue Mar 11, 2020 · 1 comment
Closed

SyntaxWarning: "is" with a literal. Did you mean "=="? #21

mkcn opened this issue Mar 11, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@mkcn
Copy link
Owner

mkcn commented Mar 11, 2020

In python 3.8 the following warning is shown:

2020-03-10T08:38:37.2701777Z /home/runner/work/fastHistory/fastHistory/fastHistory/parser
/inputParser.py:234: SyntaxWarning: "is" with a literal. Did you mean "=="?
2020-03-10T08:38:37.2702595Z elif string is "":
2020-03-10T08:38:37.2703067Z /home/runner/work/fastHistory/fastHistory/fastHistory/database/databaseSQLite.py:469: SyntaxWarning: "is not" with a literal. Did you mean "!="?
2020-03-10T08:38:37.2703637Z if new_description is not None and new_description is not "" and new_description != old_description:
2020-03-10T08:38:37.2704115Z /home/runner/work/fastHistory/fastHistory/fastHistory/database/databaseSQLite.py:470: SyntaxWarning: "is" with a literal. Did you mean "=="?
2020-03-10T08:38:37.2704540Z if old_description is "":
2020-03-10T08:38:37.2705009Z /home/runner/work/fastHistory/fastHistory/fastHistory/database/databaseSQLite.py:550: SyntaxWarning: "is" with a literal. Did you mean "=="?
2020-03-10T08:38:37.2705443Z if new_cmd is None or new_cmd is "":
2020-03-10T08:38:37.2705880Z /home/runner/work/fastHistory/fastHistory/fastHistory/pick/pageGeneric.py:76: SyntaxWarning: "is not" with a literal. Did you mean "!="?
2020-03-10T08:38:37.2707169Z if index_sub_str is not -1:

@mkcn mkcn added the bug Something isn't working label Mar 11, 2020
@mkcn
Copy link
Owner Author

mkcn commented Mar 11, 2020

fixed in ac9943e
this may be needed to be reopen in the future

@mkcn mkcn closed this as completed Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant