Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shall I share my Dockerfile? #1

Closed
hoechenberger opened this issue Jan 12, 2021 · 8 comments
Closed

Shall I share my Dockerfile? #1

hoechenberger opened this issue Jan 12, 2021 · 8 comments

Comments

@hoechenberger
Copy link
Member

hoechenberger commented Jan 12, 2021

Hello, I've already created an MNE Dockerfile that also starts Xvfb to allow for 3d rendering. Shall I just dump that here? Or what is the intended procedure for this repo?

Best wishes!

@agramfort
Copy link
Member

agramfort commented Jan 12, 2021 via email

@SherazKhan
Copy link
Member

@hoechenberger I think we need to have two types of dockers, one a base image for cloud distributed computing and the second for the interactive work inherited from Jupyter notebook image with Xvfb binding.

We can also offer a third type of docker image with freesurfer and MNE-C.

Please contribute your docker, we can follow, dask-docker repository structure

@SherazKhan
Copy link
Member

@hoechenberger @agramfort please guide me in setting up GitHub actions for CI

@agramfort
Copy link
Member

@hoechenberger
Copy link
Member Author

@hoechenberger I think we need to have two types of dockers, one a base image for cloud distributed computing and the second for the interactive work inherited from Jupyter notebook image with Xvfb binding.

I will make a "base" image with Xvfb so you can get 3D rendering e.g. for inclusion in reports (this one is almost ready), and then we can offer another one which builds upon the first one and simply adds the Jupiter server. Not entirely sure if it will be worth the effort providing two separate images, though, but let's see how things go.

We can also offer a third type of docker image with freesurfer and MNE-C.

FS integration is actually quite an interesting question, because I'd want to have FS run in a separate container. We'd need to see how we can pass data between those. But that's a detail for later.

@hoechenberger @agramfort please guide me in setting up GitHub actions for CI

Do you want CI or do you want continuous deployment..?
For the latter, see @agramfort's comment

For the former, I don't see the need at this stage :)

@SherazKhan
Copy link
Member

I will make a "base" image with Xvfb so you can get 3D rendering e.g. for inclusion in reports (this one is almost ready), and then we can offer another one which builds upon the first one and simply adds the Jupiter server. Not entirely sure if it will be worth the effort providing two separate images, though, but let's see how things go.

@hoechenberger @agramfort I think, the Docker base image intended for scheduler and workers should be as light as possible to reduce startup time when starting new cloud clusters.

FS integration is actually quite an interesting question, because I'd want to have FS run in a separate container. We'd need to see how we can pass data between those. But that's a detail for later.

Agree!

Do you want CI or do you want continuous deployment?
Both CI and CD, for CD I will try @agramfort suggestion,

Since we want to update Dockerfile with every mne release, I was wondering if there is any way to set up a testing environment for the Docker images?

@rob-luke
Copy link
Member

Hi @hoechenberger I would love to see your docker file that has 3d rendering capabilities. No worries if its messy, warts and all, I can help clean it up.

I have a public webinar coming up and was hoping that I could get a docker image up and running to easily onboard people during the talk.

@larsoner
Copy link
Member

There should be 3D capabilities in this now in the -plot variant but @hoechenberger feel free to share your dockerfile at some point!

Would be cool to deduplicate efforts here and mne-tools/mne-python#12306 if relevant as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants