Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve the history of destroyed vessels for future viewing #3494

Open
eggrobin opened this issue Dec 31, 2022 · 1 comment
Open

Preserve the history of destroyed vessels for future viewing #3494

eggrobin opened this issue Dec 31, 2022 · 1 comment

Comments

@eggrobin
Copy link
Member

Scripsit @lpgagnon:

After about a year, the moon ate my first moon orbiter while I wasn't looking. As I try to find an older save from which I can watch the end, I wonder: would it be possible to preserve the history of destroyed vessels for future viewing?

Relatedly, it would be nice to not lose all history upon landing.

Now that we have solved #2400 once and for all—but—Once and for all!, we should be able to do that without ridiculously enlarging saves. We already have zombies, this would be a matter of adding more stuff to them, and coming up with a way to look at that in the case of destroyed vessels.

// Contains the adaptive step parameters for the vessel that existed in the
// past but are no longer known to the plugin. Useful to avoid losing the
// parameters, e.g., when a vessel hits the ground.
// NOTE(phl): This is a leaky map, in the sense that we don't remove deleted
// vessels from it. Hopefully it's small enough that we don't care.
std::map<GUID, Ephemeris<Barycentric>::AdaptiveStepParameters>
zombie_prediction_adaptive_step_parameters_;

@eggrobin
Copy link
Member Author

(It is amusing to note that looking at such zombie trajectories could require reanimation.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant