-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A crash occurred while entering orbit (Visual C++ Runtime Library) #4038
Comments
This error is typically due to a corruption or conflict in the Visual C++ runtime. Please make sure that you have a single version of the Microsoft Visual C++ 2015-2022 Redistributable installed, and that it's at least version 14.38.33130. If you do have multiple versions, I suggest uninstalling them all and installing the latest version from the Microsoft site https://aka.ms/vs/17/release/vc_redist.x64.exe. |
Thanks, but sadly it doesn't work and the same crash is still happening. |
This is going to be hard to analyse because it's very likely to be related to the environment on your computer. You might want to send us a PML file by following the instructions here. This might help find the anomaly, although that's not guaranteed. |
I'm not very familiar with it. If I'm doing it correctly,here is should be the expected PML file. Hope it helps. |
Breakthrough: The game doesn't crash without the use of Kerbin Fixed Coordinate System. The problem seems to happen when drawing a path that doesn't strike the ground. (It seems to me so, but I don't guarantee that I don't understand how Principia works.) |
You did record the (I have a hunch that we have a bug in the interchange between C# and C++ when computing the intersection of the trajectories with the ground. We had a problem that was vaguely similar in #3872, and I don't think that we got to the bottom of it.) |
I was able to load your save, but I couldn't reproduce the crash (I tried various setting of the prediction in the hope of stress-testing the terrain collision algorithm). |
I'll have time soon to try to get the log file and send it. During these days, I carefully avoided using the coordinatesystem, and the game worked fine and there were no crashes. It seems that the error only happens on stable tracks. If you are in a flyover or impact orbit, then the coordinate system will not cause a crash. |
For what it's worth I am attaching below the stack of the last load of the C++ runtime, obtained from the Principia/ksp_plugin/interface_collision.cpp Lines 66 to 70 in b381917
The interesting part is that the stack is still at the same addresses in Principia and |
Could you give us a journal by following the instructions here? At this point I am convinced that the problem has to do with the computation of collisions, which we only do in the Kerbin surface frame. I would like to see the last interactions between the C# and C++ code before the crash. |
The Principia/ksp_plugin/interface_collision.cpp Lines 134 to 143 in b381917
Principia/base/not_null_body.hpp Line 207 in b381917
There are the computations of the collisions. Note that presumably all the corresponding calls to CollisionDeleteExecutor succeeded until the last one.
|
The journal file on Kerbin's orbit is so large that I couldn't upload it after trying many ways. I suggest you take a look at the example on the Mun's orbit first. Interestingly, the game behaves even stranger when journal recording is turned on. In the case of Mun orbit's satellites, the crash no longer occurs immediately. It took me several times to switch the camera and coordinate system before I was able to reproduce the crash. (Maybe it's just because the computer is old and the game is slow.) |
The journal indeed ends with the deletion of an executor:
but the crash doesn't reproduce on my machine. Things that we have been looking into:
|
#3872 seems to be another occurrence of the same problem. The Excerpt from the #3872 log:
Excerpt from the log for this issue:
This might indicate that the problem is related to FMA. I have to believe that most of our users are using processors that have FMA (FMA was introduced by AMD in 2012 and by Intel in 2013) so it is possible that we misbehave (or that the Visual C++ Runtime misbehaves) on processors that don't have FMA support. Unfortunately, we don't have easy access to machines without FMA, so if this is the root cause it's going to be hard to investigate. |
The game crashes just about to enter a Kerbin circular orbit, and then this appears.
![dialog box](https://private-user-images.githubusercontent.com/107014777/348468074-85f3b1c3-c7b3-41dc-8218-4954d794e6ae.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYwMDU3MDksIm5iZiI6MTcyNjAwNTQwOSwicGF0aCI6Ii8xMDcwMTQ3NzcvMzQ4NDY4MDc0LTg1ZjNiMWMzLWM3YjMtNDFkYy04MjE4LTQ5NTRkNzk0ZTZhZS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwOTEwJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDkxMFQyMTU2NDlaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0xYjM1YzhjN2MzNjVkODU1YjI4YTJmZjFlYWY4NzAwNzlkN2FkNjI2N2U5MTA1YTMyYzgzZWYwMDk2NzcwOTk1JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.SUiNdAcqTmupJJ4aZ2ytIu679Z4_tDlxGb517_1UtWM)
Here's the glog.
No files were produced in the crash folder.
How to reproduce:
Additional Information:
The text was updated successfully, but these errors were encountered: