Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release monochrom #1

Closed
1 of 5 tasks
cmungall opened this issue Jul 2, 2019 · 8 comments
Closed
1 of 5 tasks

Release monochrom #1

cmungall opened this issue Jul 2, 2019 · 8 comments

Comments

@cmungall
Copy link
Member

cmungall commented Jul 2, 2019

minimal for release

  • Create a GH repo using ODK
    • we would do a manual step of copying the ttl to this repo
  • Ensure all labels are included
  • Fix OWL errors (see below)

OWL error:

image

things to include in future

not urgent, just good to have them tracked

  • syntenic regions
  • chromosome positions
@cmungall
Copy link
Member Author

cmungall commented Jul 2, 2019

I am making the repo. Will need some tidying to look like a normal editfile

@cmungall
Copy link
Member Author

cmungall commented Jul 2, 2019

@kshefchek kshefchek transferred this issue from monarch-initiative/dipper Aug 13, 2019
@TomConlin
Copy link

@TomConlin note to self figure out populating this from dipper

@matentzn
Copy link
Member

@cmungall, is this correct that before makeing a release, we download the turtle dump from dipper using a make goal like:

edit:
	wget https://data.monarchinitiative.org/ttl/monochrom.ttl -O chr-edit.ttl

Seems that your current chr-edit.ttl differs massively (huge diff, but also things like ontology header which is not present in the dipper dump). What other processing does chr-edit.ttl need after the above download?

@cmungall
Copy link
Member Author

Yes, something like that (apologies, I should have included this in the Makefile). It looks like it was passed through the owlapi in the first place (the Error1s).

Are you sure the diff is so large? Is this ascii, rdf-level, or owl-level?

Note also this would be the point of comparison (or even the version before this).
https://archive.monarchinitiative.org/201907/ttl/monochrom.ttl

I would not worry too much about replicating the original edit file. There was no manual massaging. Let's just start with the existing one and move forward. There are some oddities to deal with. Not sure if it makes sense to fix these as dipper or as post-processing.

The main oddities are in the rdf/owl conversion.

@matentzn
Copy link
Member

Ah I only now saw this with the OWL errors - this needs to be fixed at dipper level.. I made a separate ticket: #2

@matentzn
Copy link
Member

I updated the ODK to the latest version and included the monochrom dipper dump as a component in the pipeline - now its all handled correctly..

I will include monochrom now as part of Monarch OLS, but I have not dealt with the Error classes yet, nor have I looked at the labels "ensure all labels are included" -> How do I do that?

@cmungall
Copy link
Member Author

dupe w #10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants