Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit the ActionButtonUseKeyDown cvar #85

Open
mooreatv opened this issue Sep 12, 2023 · 2 comments
Open

Revisit the ActionButtonUseKeyDown cvar #85

mooreatv opened this issue Sep 12, 2023 · 2 comments

Comments

@mooreatv
Copy link
Owner

Goal would be to have /click work in macros without

https://github.com/mooreatv/DynamicBoxer/blob/v3.11.04/DynamicBoxer/DBoxInit.lua#L28-L29

Stanzilla/WoWUIBugs#317 (comment)

The idea in the Github comment does let you do an action on button up 
local button = CreateFrame("Button", "PMDemoButton", UIParent, "UIPanelDynamicResizeButtonTemplate,SecureActionButtonTemplate")
button:SetPoint("CENTER")
button:SetText("Demo")
DynamicResizeButton_Resize(button)
button:RegisterForClicks("AnyUp");
button:SetAttribute("type", "macro")
button:SetAttribute("macrotext", "/run print(\"hey\")");

button:SetAttribute("pressAndHoldAction", true);
button:SetAttribute("typerelease", "macro");

Though we don't want stuff to require more arguments/changes to macros

ie /click FooButton should just work (as in trigger in mama) without having users having to rewrite all the places they put it to add a 1
we don't need it to be on up, down is fine/faster and I don't hack 2 actions in 1 key either (ie diff on down and up)
oh and work the same for a addon keybind right now I have plain <Binding ...> in the bindings.xml

https://discord.com/channels/525590038608740363/610205215475499092/1151275158389137449

@mooreatv
Copy link
Owner Author

@mooreatv
Copy link
Owner Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant