Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keeping Isometry3d in ROS2 #32

Closed
davetcoleman opened this issue Mar 1, 2019 · 4 comments
Closed

Keeping Isometry3d in ROS2 #32

davetcoleman opened this issue Mar 1, 2019 · 4 comments

Comments

@davetcoleman
Copy link
Member

A change was made by @rhaschke in ros1/geometry2 that was not forward ported to ros2/geometry2, see ros/geometry2#335.

This change urgently needs to be ported so that there isn't a big regression in the moveit2 codebase as demonstrated here and in the related conversation: #12 (comment)
@vmayoral vmayoral mentioned this issue Mar 3, 2019
Closed
@vmayoral
Copy link
Contributor

vmayoral commented Mar 3, 2019

ros2/geometry2#93 addresses the issue in geometry2. Changes like 94ebbcc should follow.

@vmayoral
Copy link
Contributor

Shall we close this @davetcoleman? @mlautman?

@davetcoleman
Copy link
Member Author

Let's wait until ros2/geometry2#93 is closed. This should actually auto-close now that I've tagged its dependency on github.

@anasarrak
Copy link
Contributor

This issue can be closed, they've merged the changes on ros2/geometry2#90

@rhaschke rhaschke closed this as completed Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@davetcoleman @vmayoral @rhaschke @anasarrak