Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation: GPO 'Tracking Protection' missing information #895

Closed
htcfreek opened this issue May 25, 2022 · 10 comments
Closed

Translation: GPO 'Tracking Protection' missing information #895

htcfreek opened this issue May 25, 2022 · 10 comments

Comments

@htcfreek
Copy link
Contributor

GPO: Tracking protection (moved)
Translation language: de-de

Missing: The phrase (moved).

This gpo movement is a bit confusing. Could you describe where it is moved to or remove the old definition because it makes the reports strange.

@htcfreek
Copy link
Contributor Author

And the readme is missing the entire tracking protection group and a hint about the movement

@htcfreek htcfreek changed the title GPO translation missing information Translation: GPO missing information May 25, 2022
@htcfreek htcfreek changed the title Translation: GPO missing information Translation: GPO 'Tracking Protection' missing information May 25, 2022
@mkaply
Copy link
Collaborator

mkaply commented May 26, 2022

The readme doesn't need to be changed when things are moved in the Windows GPO. The content is in the same place as it always was:

https://github.com/mozilla/policy-templates/#enabletrackingprotection

All that changes is where it is located in the GPO UI and the Intune URLS.

Again, I'm unclear as to what you mean by "reports"

@htcfreek
Copy link
Contributor Author

htcfreek commented May 26, 2022

Again, I'm unclear as to what you mean by "reports"

This page/overview (example image from web): https://images.app.goo.gl/78ZWrJ8KDcrhvh5b9

@htcfreek
Copy link
Contributor Author

@mkaply
I think the first step here is fixing the translation and add the movement note. (Can do this too.)

The second step is to evaluate how the code has to be improved that the overview/report is correct: Only the configured policies shows as configured. (Screenshot about the current behavior come tomorrow.)

@htcfreek
Copy link
Contributor Author

htcfreek commented May 27, 2022

Here is a screenshot of the problem with the incorrect report/configuration overview:

image

image

@mkaply
Copy link
Collaborator

mkaply commented May 31, 2022

This seems like a Microsoft bug when something is duplicated in two places in the GPO.

What's the command you run to generate this specific report? My report doesn't show the Firefox items.

@htcfreek
Copy link
Contributor Author

htcfreek commented May 31, 2022

This seems like a Microsoft bug when something is duplicated in two places in the GPO.

Yes. Seen today that some settings from ms templates are affected too. There is a conflict between printer.admx and ms-securityguid admx templates. 😅

What's the command you run to generate this specific report? My report doesn't show the Firefox items.

There is no command. The report is generated by the "Group Policy Management Application".

But you can try to reproduce it locally with the following steps:

  1. Copy the admx and adml-folder to c:\windows\policy definition
  2. set gpo via gpedit.msc
  3. run gpresult /h c:\mypath.html in cmd
  4. open html file and see if it contains the ff policies

@htcfreek
Copy link
Contributor Author

htcfreek commented May 31, 2022

A small description how gpos work:

The admx/adml files define which settings are existing.

If you set one, then the registry path is written in a file called registry.pol and the comments are written into the comments.cmtx file. For each gpo object there is one file set for user context and one for machine context.

Client configuration
The registry.pol files will be synced to the client and the client reads them and sets the reg values in its registry. (There a program can read them.)

Reports
The report reads the registry.pol file and assigns the reg values to the values in the admx/adml files. So if there are two definitions for a reg key it makes sense that you get incorrect things in the reports as the 1:1 assignment isn't working anymore.

Mapping of report comments
The comments are mapped based on the admx file name and the policy file name/id. (For example "firefox.admx" and "E_TrackingProtection_Locked".)

@mkaply
Copy link
Collaborator

mkaply commented May 31, 2022

So I guess the real question is then do I need to have them in two places? Or if I move a policy and then remove the old one, will the new setting be set?

@htcfreek
Copy link
Contributor Author

htcfreek commented May 31, 2022

So I guess the real question is then do I need to have them in two places? Or if I move a policy and then remove the old one, will the new setting be set?

You don't need two place (Except when the regkey path/value changes.)

Then only thing that will happen is that the comments created by the admin will be lost/can't be assigned to show in the management ui anymore. (The comments are mapped based on the admx file name and the policy file name/id. For example "firefox.admx" and "E_TrackingProtection_Locked".)

But if you write a hint in the release notes admins can export a report/makes screenshot and create the comments again. So I think it won't be a problem to remove the old entries in the admx.

@mkaply mkaply closed this as completed in 1f33723 Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants