-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document how to depend on source-map 0.6.X for old nodes and 0.7.0 for new nodes #313
Comments
Folks, there's a reason that a "+1" button exists: so you don't have to leave a comment containing only "+1". |
I have no interest maintaining two versions of source map parsing and querying, nor incurring the additional code size bloat. I suggest using the old version of the library if you have to support old node versions, or alternatively setting up some kind of feature detection scheme. I'll leave this issue open for adding documentation on how to depend on 0.6.X for old nodes and 0.7.0 for new ones. |
For users of Yarn
This may be useful while we wait for downstream packages to update for the changes in 0.7.0 (or pin to 0.6.x). Is there a similar solution for NPM users? |
Why doesn't this project follow semver so that I'm protected from this version? |
It does; semver treats major version 0 specially. I think it would probably be a good idea to just admit that this package is heavily used and release 1.0. |
That sounds good to me |
In the meantime node <8 has become less relevant (I'll claim) and |
We're currently working on source map support in Parcel: parcel-bundler/parcel#506. We'd love to take advantage of the WASM version of source-map in 0.7, but we also need to support Node < 8 users. Is there a way the source-map library could fall back to a JS version for Node < 8 users?
The text was updated successfully, but these errors were encountered: