Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need glTF model including lights extension #18629

Closed
3 of 13 tasks
takahirox opened this issue Feb 13, 2020 · 5 comments · Fixed by #25506
Closed
3 of 13 tasks

We need glTF model including lights extension #18629

takahirox opened this issue Feb 13, 2020 · 5 comments · Fixed by #25506
Labels

Comments

@takahirox
Copy link
Collaborator

Description of the problem

We have removed glTF Monster model in #18579. It was the only glTF model which has lights extension in our examples. I think we need a new model (or another existing model) which has lights extension for the test and showing we support lights extension.

Three.js version
  • Dev
  • r113
  • ...
Browser
  • All of them
  • Chrome
  • Firefox
  • Internet Explorer
OS
  • All of them
  • Windows
  • macOS
  • Linux
  • Android
  • iOS
Hardware Requirements (graphics card, VR Device, ...)
@mrdoob mrdoob added this to the r115 milestone Feb 13, 2020
@cx20
Copy link
Contributor

cx20 commented Feb 14, 2020

The only glTF model that corresponds to the Lights extension I know is the following PR.
KhronosGroup/glTF-Sample-Models#210

@donmccurdy
Copy link
Collaborator

Yeah, the current examples available aren't really clear — you can see that there is light, but it's not obvious whether the lighting configuration is right. It would probably be best to create a new example in Blender, with clear success/failure modes like this sample: https://github.com/KhronosGroup/glTF-Sample-Models/tree/master/2.0/AlphaBlendModeTest.

@cx20
Copy link
Contributor

cx20 commented Feb 16, 2020

Of course, it is desirable that there is a cool model. Unfortunately, I still don't know that.

@emackey Do you have any advice?

@emackey
Copy link

emackey commented Feb 19, 2020

Someday I hope to find the time to make such a sample model for punctual lights. Right now I seem to have my hands full with clearcoat and other PBR Next extensions.

@mrdoob mrdoob modified the milestones: r115, r116 Mar 25, 2020
@mrdoob mrdoob modified the milestones: r116, r117 Apr 30, 2020
@mrdoob mrdoob modified the milestones: r117, r118 May 27, 2020
@mrdoob mrdoob modified the milestones: r118, r119 Jun 24, 2020
@mrdoob mrdoob modified the milestones: r119, r120 Jul 29, 2020
@mrdoob mrdoob modified the milestones: r120, r121 Aug 25, 2020
@mrdoob mrdoob modified the milestones: r121, r122 Sep 29, 2020
@mrdoob mrdoob modified the milestones: r122, r123 Oct 28, 2020
@mrdoob mrdoob modified the milestones: r123, r124 Nov 25, 2020
@mrdoob mrdoob modified the milestones: r124, r125 Dec 24, 2020
@mrdoob mrdoob modified the milestones: r125, r126 Jan 27, 2021
@mrdoob mrdoob removed this from the r126 milestone Feb 23, 2021
@mrdoob mrdoob added this to the rXXX milestone Feb 23, 2021
@Mugen87
Copy link
Collaborator

Mugen87 commented Nov 21, 2022

We could make a new example with https://github.com/KhronosGroup/glTF-Sample-Models/tree/master/2.0/LightsPunctualLamp.

The asset also makes use of KHR_materials_transmission. When testing, I have noticed some light glitches on the lampshade though when moving the camera (the surfaces sometimes flickers at the top of the lampshade).

https://raw.githack.com/Mugen87/three.js/dev72/examples/webgl_loader_gltf_lights.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants