Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msg.blob should be named msg.buffers #14

Closed
rgbkrk opened this issue Sep 24, 2016 · 2 comments
Closed

msg.blob should be named msg.buffers #14

rgbkrk opened this issue Sep 24, 2016 · 2 comments

Comments

@rgbkrk
Copy link
Contributor

rgbkrk commented Sep 24, 2016

To match the Notebook websockets

@n-riesco
Copy link
Owner

I think buffers is a bit of a misnomer. But since jupyter-notebook and jupyter-client use this name, jmp'd better do the same.

I guess the messaging spec should also be updated too (here and here).

@rgbkrk
Copy link
Contributor Author

rgbkrk commented Sep 26, 2016

I think buffers is a bit of a misnomer.

Yeah, I agree. I mostly care about consistency since we have a light abstraction layer that works across the websockets and zmq in enchannel. This was the only field that differed.

I think I'll start out with opening an issue on jupyter_client before I make any PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants