Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract error message text to variable #16

Open
virtser opened this issue Jan 6, 2021 · 1 comment
Open

Extract error message text to variable #16

virtser opened this issue Jan 6, 2021 · 1 comment

Comments

@virtser
Copy link

virtser commented Jan 6, 2021

Can the error message "No ticket was referenced in this pull request" be extracted into variable please?
So we can override it with our own wording.

Also, it will be very useful to actually write this error message as comment in PR so developer won't have to go into Github actions workflow details to see why it failed.

And one more option that will be useful is to allow not to fail the PR on miss of ticket link, but warn with a message. This is especially useful for the first phase of people to get used to it..

@pqt
Copy link
Contributor

pqt commented Jan 22, 2021

Hey @virtser!

Can the error message "No ticket was referenced in this pull request" be extracted into variable please?
So we can override it with our own wording.

I've got a PR up for this now on #17

Also, it will be very useful to actually write this error message as comment in PR so developer won't have to go into Github actions workflow details to see why it failed.

This is actually already implemented and made available with the quiet input option (See the last row of https://github.com/neofinancial/ticket-check-action#inputs). Make sure that's set to false and you'll start receiving comments.

And one more option that will be useful is to allow not to fail the PR on miss of ticket link, but warn with a message. This is especially useful for the first phase of people to get used to it..

The actions API only allows two states which are pass or fail.

You can however choose not to make this a required check using GitHub branch options. This would mean that the check would fail (which, objectively is correct) but does not block the merging of code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants