Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add license file to v3 and v3/newrelic #254

Merged
merged 1 commit into from
Jan 7, 2021
Merged

fix: Add license file to v3 and v3/newrelic #254

merged 1 commit into from
Jan 7, 2021

Conversation

tydavis
Copy link
Contributor

@tydavis tydavis commented Dec 17, 2020

Adds license file to v3/ and v3/newrelic/ subdirectories to make the
repository compatible with pkg.go.dev (in particular,
https://pkg.go.dev/github.com/google/licensecheck).

Resolves #169 #169

Adds license file to v3/ and v3/newrelic/ subdirectories to make the
repository compatible with pkg.go.dev (in particular,
https://pkg.go.dev/github.com/google/licensecheck).

Resolves #169 #169
@CLAassistant
Copy link

CLAassistant commented Dec 17, 2020

CLA assistant check
All committers have signed the CLA.

@tydavis
Copy link
Contributor Author

tydavis commented Dec 17, 2020

@jthurman42 - bringing this to your attention

@tydavis
Copy link
Contributor Author

tydavis commented Dec 17, 2020

I'm not sure why the two integration tests failed?
https://github.com/newrelic/go-agent/pull/254/checks?check_run_id=1573077495
https://github.com/newrelic/go-agent/pull/254/checks?check_run_id=1573077118

88
	github.com/newrelic/go-agent/v3/integrations/nrawssdk-v2.test imports
89
	github.com/aws/aws-sdk-go-v2/service/dynamodb imports
90
	github.com/awslabs/smithy-go/httpbinding: package provided by github.com/awslabs/smithy-go at latest version v0.4.0 but not at required version v0.4.1-0.20201216214517-20e212c92831 

and

25
	/opt/hostedtoolcache/go/1.13.15/x64/src/github.com/aws/aws-sdk-go-v2/private/protocol/rest (from $GOROOT)
26
	/home/runner/work/go-agent/go-agent/src/github.com/aws/aws-sdk-go-v2/private/protocol/rest (from $GOPATH)
27
package github.com/aws/aws-sdk-go-v2/aws/external: cannot find package "github.com/aws/aws-sdk-go-v2/aws/external" in any of:
28
	/opt/hostedtoolcache/go/1.13.15/x64/src/github.com/aws/aws-sdk-go-v2/aws/external (from $GOROOT)
29
	/home/runner/work/go-agent/go-agent/src/github.com/aws/aws-sdk-go-v2/aws/external (from $GOPATH)

Look to be errors with the versioned aws-sdk libraries?

@jodeev jodeev added this to To Do in Go Engineering Board Dec 17, 2020
@tydavis
Copy link
Contributor Author

tydavis commented Dec 22, 2020

Are there any concerns or blockers to merging this issue? I'm unsure how to resolve the AWS SDK build test issues.

@Clivern
Copy link

Clivern commented Dec 27, 2020

It would be nice to merge this since go pkg docs not showing for v3 https://pkg.go.dev/github.com/newrelic/go-agent/v3/integrations/logcontext/nrlogrusplugin

@tydavis
Copy link
Contributor Author

tydavis commented Jan 4, 2021

Bumping this again - @jthurman42 @jodeev any issues with merging?

@RichVanderwal RichVanderwal changed the base branch from master to develop January 7, 2021 00:21
Copy link
Contributor

@RichVanderwal RichVanderwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, @tydavis ! Merging to develop now and releasing soon.

@RichVanderwal RichVanderwal merged commit 37634dd into newrelic:develop Jan 7, 2021
Go Engineering Board automation moved this from To Do to Done Jan 7, 2021
@tydavis tydavis deleted the issue-169 branch January 7, 2021 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Documentation on pkg.go.dev not available due to licence file and tags
4 participants