Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NR Open Source repolinter GitHub action setup #262

Merged
merged 1 commit into from
Jan 7, 2021

Conversation

RichVanderwal
Copy link
Contributor

Hello from the Open Source and Developer Advocacy team at New Relic.

This PR contains a GitHub actions workflow which runs repolinter, an automated tool to help us find and fix inconsistencies in our community files and public repositories. This PR registers a GitHub Actions workflow (repolinter.yml) running repolinter-action. The goal of this workflow is to make our Open Source Policy enforcement more consistent and transparent for everyone.

Repolinter Action does:

  • Scans the repository for Open Source policy issues using Repolinter.
    • The issues this workflow scans for are determined by the ruleset specified by with.config-url: this ruleset will be maintained by the Open Source and Developer Advocacy team and will not change frequently.
  • Runs only on push to the default branch, ignoring PRs and other events.
  • If any policy issues are found, this workflow will open a GitHub issue titled "Open Source Policy Issues" and with the repolinter label. This issue will contain detailed information on which policies generated errors and what changes are suggested. An example issue is here.
  • As policy issues are resolved, this workflow will update the open issue to reflect the changes. If all policy issues are resolved, the issue will automatically be closed.

This workflow is designed to cause the least amount of friction as possible:

  • This means workflow will only run on push, and as a result will not participate in status checks for PRs. Furthermore, this workflow will always exit with a passing status unless a fatal internal error occurs.
  • The goal of this workflow was not to prevent work: this means that it is up to your team to backlog the items found by this tool appropriately.
  • This workflow will only notify you when an issue is created. In other words, you will only be notified when new problems occur, but not when existing problems change.

What you should do:

  • Review this PR and workflow: make sure that the correct base branch is selected.
  • If it looks good, merge the PR and check to see if the repolinter-action runs successfully in the actions console. You can remove the branch created by this PR as it is no longer needed.
  • If you have concerns, please address them in the #help-opensource channel in Slack.
  • If there's a blocked with the CLA Assistant check of my handle (tangollama), please ignore it. I (Joel) have indeed signed our CLA... several times. The fact that the tool may not acknowledge that is deficiency in our tooling that we will address in due time.
  • The action may open a GitHub issue on this repository (it will have the repolinter label). If an issue is opened, look it over and make sure all the problems seem correct. Shoot us a ping in #help-opensource if anything looks suspicious.
  • In the future, this workflow may open issues as our open source policies are updated. Keep an eye on the GitHub issues for these updates (it may help to watch the repository).

This workflow is still in beta! If you have feedback, please let us know in #help-opensource.

Thank you for your cooperation with this policy.

@RichVanderwal RichVanderwal added this to Triage in Go Engineering Board via automation Jan 7, 2021
@RichVanderwal RichVanderwal self-assigned this Jan 7, 2021
Copy link

@tangollama tangollama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for getting this added Rich. 🚢 it.

@RichVanderwal RichVanderwal merged commit c43b709 into newrelic:develop Jan 7, 2021
Go Engineering Board automation moved this from Triage to Done Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants