Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix command for StartExternalSegment #320

Merged
merged 1 commit into from
Jun 1, 2021
Merged

Fix command for StartExternalSegment #320

merged 1 commit into from
Jun 1, 2021

Conversation

abeltay
Copy link
Contributor

@abeltay abeltay commented May 31, 2021

Details

There is no command for txn.StartExternalSegment for both v3 version and non-v3

func StartExternalSegment(txn Transaction, request *http.Request) *ExternalSegment {

func StartExternalSegment(txn *Transaction, request *http.Request) *ExternalSegment {

This PR updates the documentation to match the actual command provided by the package.

@CLAassistant
Copy link

CLAassistant commented May 31, 2021

CLA assistant check
All committers have signed the CLA.

@abeltay abeltay changed the base branch from master to develop May 31, 2021 05:53
@RichVanderwal RichVanderwal merged commit 78fda45 into newrelic:develop Jun 1, 2021
@RichVanderwal RichVanderwal linked an issue Jul 1, 2021 that may be closed by this pull request
@RichVanderwal RichVanderwal self-assigned this Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix GUIDE.md regarding StartExternalSegment
3 participants