Handle attributes in nrpkgerrors #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that if an error contains attributes, that they are safely coppied into the new error created in the wrap function.
| @@ -902,7 +902,7 @@ func TestTrObsOKSendBackoffNo(t *testing.T) { | |||
| } | |||
| // If the default backoff of 15 seconds is used, the second span will not | |||
| // be received in time. | |||
| if !s.DidSpansArrive(t, 2, 4*time.Second) { | |||
| if !s.DidSpansArrive(t, 2, 8*time.Second) { | |||
There was a problem hiding this comment.
I'd love to find a better solution to this. I've increased this timeout myself in a past PR.
There was a problem hiding this comment.
+1 this is a very naive attempt at solving the problem. I would really like to understand why it is happening in the first place.
There was a problem hiding this comment.
Can we set a variable for the integer here?
RichVanderwal
moved this from Awaiting User Input
to Code Review
in Go Engineering Board
nr-swilloughby
approved these changes
May 10, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixes #409. nrpkgerrors.Wrap() now checks if the error it is passed has attributes, and if it does, copies them into the New Relic error it creates.