Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Componentize Helmet #142

Closed
doctyper opened this issue Apr 25, 2016 · 2 comments
Closed

Componentize Helmet #142

doctyper opened this issue Apr 25, 2016 · 2 comments
Labels
enhancement

Comments

@doctyper
Copy link
Contributor

Now that we are covering the full suite of elements that can be used in <head>, it might be time to think about componentizing (is that a word?) Helmet. Having so many potential properties in one <Helmet /> tag makes it look a little long in the tooth. @potench suggested this nested API as a possibility:

<Helmet>
    <Title>
    <Meta>
    <Script>
</Helmet>

Thoughts?
@mattecapu
Copy link

I'd go with

<Helmet.Head>
    <Helmet.Title>
    <Helmet.Meta>
    <Helmet.Script>
</Helmet.Head>

To better distinguish the components from the plain HTML tags

@doctyper
Copy link
Contributor Author

Done via #246.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@doctyper @cwelch5 @mattecapu