Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove PRIMARY_TYPES reliance from library #13

Open
nftchance opened this issue Oct 3, 2023 · 0 comments
Open

feat: remove PRIMARY_TYPES reliance from library #13

nftchance opened this issue Oct 3, 2023 · 0 comments
Assignees
Labels
critical Complete with a high sense of urgency.

Comments

@nftchance
Copy link
Owner

nftchance commented Oct 3, 2023

Now that we have to write our version of an intent protocol (#10), it has become apparent that we must remove the base implementations of the types. This is only possible because by including the 712 types in the library, we are operating with the assumption that the protocol:

1.) Already exists.
2.) Has been tested.

But, to test the protocol, we need the library because we need to be able to sign the messages. This means that for this to work, we must convert the library to be purely generic and extensible. While this is unfortunate right now, at least this means that it is unlikely we have backward compatibility issues created by protocol updates.

Tests that test the protocol should be localized to the protocol, and library functionality should be tested in the library. With this direction, we are to assume that the dependency in each environment is always assumed to function.

An interesting thing that the developers of Delegatable did was declare the top level of the EIP-712 interface values. Using that, they generate the Solidity code.

@nftchance nftchance self-assigned this Oct 3, 2023
@nftchance nftchance added the critical Complete with a high sense of urgency. label Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
critical Complete with a high sense of urgency.
Projects
None yet
Development

No branches or pull requests

1 participant